Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant degree check on commit key/commit #705

Open
vlopes11 opened this issue Aug 17, 2022 · 1 comment
Open

Redundant degree check on commit key/commit #705

vlopes11 opened this issue Aug 17, 2022 · 1 comment

Comments

@vlopes11
Copy link
Contributor

Why is it safe to use the default?

Originally posted by @moCello in #700 (comment)

@ashWhiteHat
Copy link
Contributor

It returns errors in two cases.

  1. polynomial coefficients are all zero
  2. polynomial degree is higher than public parameters length

https://github.com/dusk-network/plonk/blob/master/src/commitment_scheme/kzg10/key.rs#L160

In my opinion.

Regarding case 1, the commitment for zero polynomial should be the identity of the curve point instead of error.
Regarding case 2, we can't commit a polynomial whose degree is higher than public parameters and should return an error instead of a return default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants