Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect ViewProps/CustomViewProps types #163

Closed
scriptex opened this issue Oct 4, 2021 · 1 comment
Closed

Incorrect ViewProps/CustomViewProps types #163

scriptex opened this issue Oct 4, 2021 · 1 comment

Comments

@scriptex
Copy link
Contributor

scriptex commented Oct 4, 2021

Based on the latest (v2.0.0) release, the CHANGELOG states that

Views doesn't accept viewClassName prop anymore, use className instead.

This is not reflected in the ViewProps as well as in the CustomViewProps.

Please note that this is a pure TypeScript error as the compiler complains about a missing prop when I try to use className instead of viewClassName.

There is an error when used the other way around: the old viewClassName makes TypeScript happy but then the browser is not happy and warns

Warning: React does not recognize the viewClassName prop on a DOM element ...

but this is okay since this prop is clearly not intended to be used anymore.

Please fix this as it is pretty minor :)

I can also submit a PR if you wish.

P.S. Thanks for the awesome lib!

@duskload
Copy link
Owner

duskload commented Oct 4, 2021

@scriptex Thanks for the report! I've published version 2.0.1 with fix.

@duskload duskload closed this as completed Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants