Skip to content
This repository has been archived by the owner on Oct 14, 2018. It is now read-only.

ImmutableOptimizations should respect react state #83

Open
dustingetz opened this issue Dec 13, 2015 · 1 comment
Open

ImmutableOptimizations should respect react state #83

dustingetz opened this issue Dec 13, 2015 · 1 comment
Milestone

Comments

@dustingetz
Copy link
Owner

No description provided.

@dustingetz
Copy link
Owner Author

And document it better while we're at it. React ships PureRenderMixin which is not a very good mixin because it doesn't default to value comparisons for the rest of our props, leading to incorrectly skip render in common cases as documented.

ImmutableOptimizations is better because it lets us list things to ref-equals check, and everything else will value-equals check. We could also invert this which I dislike, because the simple cases - like passing a small record {id: 10, text: "hi"} - should work by default. Opt in to the optimizations.

@dustingetz dustingetz added this to the 2.0 milestone Jan 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant