Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can there be a copy annotation option in the sub-menu? #8

Closed
rishacha opened this issue Jan 28, 2024 · 6 comments
Closed

Can there be a copy annotation option in the sub-menu? #8

rishacha opened this issue Jan 28, 2024 · 6 comments

Comments

@rishacha
Copy link

rishacha commented Jan 28, 2024

Background

I have successfully setup the annotation plugin, but I really need a copy annotation button.

Motivation

I don't understand the use of sync using the lastsync timestamp.

I would rather prefer that the annotations stored in calibre can be directly copied from the preview when required.

Resolution

Is this something that has to be changed in calibre or is it something to do with the plugin?

I haven't investigated both in depth, but wanted to know your view on this.

I can also buy you some coffee if this is resolved 😉

@duydl
Copy link
Owner

duydl commented Feb 1, 2024

I would rather prefer that the annotations stored in calibre can be directly copied from the preview when required.

What did you mean by "preview", the Calibre's Highlight panel? I tried to imitate the behavior of Logseq's pdf highlight and is probably as close as it could get.
I could implement a drop-down search utils to search highlights of a book and import it into Calibre instead of syncing though, if this is what you meant.

I will be busy till the later half of this month, so not any serious progress until then.

@rishacha
Copy link
Author

rishacha commented Feb 1, 2024

So if I right click on the PDF Preview in Logseq, I can copy reference of the highlight and paste it inside any note.

Is something like this possible with the plug-in? I tried some tinkering and figured out that you're just rendering an iframe using the content server. So my guess is, the copy reference feature has to be implemented in the webview (content server)

This is something cumbersome. So I'm inclined to an in-built reader/preview pane that mimics the functionality of the pdf reader. I doubt that calibre will work as well in this case unless changes like these are made.

@duydl
Copy link
Owner

duydl commented Feb 2, 2024

Understand.
Then it would need to be a modification from calibre. Right now you could copy the info of highlights - the operation is convenient enough but could be optimized. Then with a little process, it could be turned into the macro link of the plugin in Logseq.

Perhaps adding a template feature for copying highlight info in Calibre ebook viewer would be a solution to the problem. I made some PR there before so it is something I could do.

@duydl
Copy link
Owner

duydl commented Feb 10, 2024

copy_hl_info
Would something like this help?

@rishacha
Copy link
Author

rishacha commented Feb 11, 2024

This is the exact feature/behaviour that I required. Thank you !! Has this been released?

@duydl
Copy link
Owner

duydl commented Apr 10, 2024

Apologize for the delay. It has been merged in calibre. kovidgoyal/calibre#2226
You can use the dev branch which would require a little setup or wait for next release.

@duydl duydl closed this as completed Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants