Skip to content
This repository has been archived by the owner on Aug 16, 2024. It is now read-only.

feat: Close Conversation Front-end #13

Merged
merged 7 commits into from
Jan 12, 2024
Merged

feat: Close Conversation Front-end #13

merged 7 commits into from
Jan 12, 2024

Conversation

wadedvsa
Copy link
Contributor

Description

This ticket is to allow the case worker to close the conversation and the user can no longer send a reply.
The command handler should close the existing conversation and mark the records on the database as closed.
The message will appear on the message tab as a closed conversation

Related issue: VOL-4689

Before submitting (or marking as "ready for review")

  • Does the pull request title follow the conventional commit specification?
  • Have you performed a self-review of the code
  • Have you have added tests that prove the fix or feature is effective and working
  • Did you make sure to update any documentation relating to this change?

fibble
fibble previously approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@fibble fibble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One v.minor comment on whitespace. Otherwise looks good.

module/Olcs/src/Controller/Messages/LicenceCloseConversationController.php Outdated Show resolved Hide resolved
@wadedvsa wadedvsa requested a review from fibble January 12, 2024 11:20
@wadedvsa wadedvsa merged commit 74f5a00 into main Jan 12, 2024
1 of 5 checks passed
@wadedvsa wadedvsa deleted the feature/VOL-4689-close-conversation-front-end branch January 12, 2024 11:33
@github-actions github-actions bot mentioned this pull request Jan 12, 2024
Open
jerotire pushed a commit to dvsa/vol-app that referenced this pull request Aug 16, 2024
@fibble
# This is a combination of 13 commits.
531179a 
# This is the 1st commit message:

WIP

# This is the commit message dvsa/olcs-internal#2:

WIP

# This is the commit message dvsa/olcs-internal#3:

WIP

# This is the commit message dvsa/olcs-internal#4:

WIP

# This is the commit message dvsa/olcs-internal#5:

WIP

# This is the commit message dvsa/olcs-internal#6:

WIP

# This is the commit message dvsa/olcs-internal#7:

WIP

# This is the commit message dvsa/olcs-internal#8:

WIP

# This is the commit message dvsa/olcs-internal#9:

WIP

# This is the commit message dvsa/olcs-internal#10:

WIP

# This is the commit message dvsa/olcs-internal#11:

WIP

# This is the commit message dvsa/olcs-internal#12:

WIP

# This is the commit message dvsa/olcs-internal#13:

WIP

WIP

WIP

WIP

WIP

VOL-3915: refactor ApplicationProcessingInspectionRequestController and a new factory

VOL-3915: add factories in OLCS/src/Controller/Application

    VOL-3915: fix ApplicationProcessingOverviewControllerTest tests

    VOL-3915: remove all getServiceLocators in ApplicationController and corresponding factory and test

    VOL-3915: remove getServiceLocators in Controller\Bus and corresponding factories

    VOL-3915: tidy tests and controllers (BusDetails/BusProcessing/BusService)

    VOL-3915: AbstractHistory controller and factory

    VOL-3915: fix ConfirmTest unit tests

    VOL-3915: fix construct for ConditionUndertakingController and factory

    VOL-3915: remove all getServiceLocators in Application/Overview and Penalty Controllers and corresponding factories

    VOL-3915: CasesController and corresponding factory

    VOL-3915: remove all getServiceLocators in ApplicationProcessingController and corresponding factory

    VOL-3915: remove all getServiceLocators in IrhpApplicationController and corresponding factory

    VOL-3915: remove all getServiceLocators in ApplicationProcessingController, LicenceController and SurrenderControllers

    VOL-3915: remove all getServiceLocators in OperatorController and LicenceController

    VOL-3915: remove all getServiceLocators in Application/ProcessingController and TransportManagerController

    VOL-3915: replaced routes declared in invokable with abstractInternalController and corresponding files

    VOL-3915: tidy up of modules and factories

    VOL-3915: replaced invokable and strings that extended abstractHistoryController

    VOL-3915: add factories for Applications/ Cases/ IrhpPermits/ Operator

    VOL-3915: tidy up - add factories for Bus/ Cases/ TransportManager

    VOL-3915: fix unit test (ConfirmTest)

    VOL-3915: add factories for Applications/ Cases/ IrhpPermits/ Operator

    VOL-3915: add correct path to navigation

VOL-3915: add factories for Sla directory

    VOL-3915: /Admin  add factories for DataRetention and controller

Remove gSL and add factories for History & Disqualify controllers

Fix disqualify & others

Revert "Fix disqualify & others"

This reverts commit e0fb5f90c384d54681e63fa1d133b3065e1bdd08.

    VOL-3915: add factories for rest of Admin directory

    VOL-3915: white screen corrections

WIP

WIP

WIP

WIP

WIP

WIP

WIP

WIP

WIP

WIP

WIP

WIP

WIP

WIP

WIP

WIP

WIP

WIP

WIP

WIP

WIP

WIP

WIP

WIP

WIP

WIP
jerotire pushed a commit to dvsa/vol-app that referenced this pull request Aug 16, 2024
@wadedvsa
feat: Close Conversation Front-end (dvsa/olcs-internal#13)
7117054 
* feat: Close Conversation popup (no confirm yet)
* feat: Call BE to close conversation
* fix: Close button disabled on conversation isClosed
* fix: FQCN for form access in controller
* fix: Sneaky whitespace somehow
* fix: Annotation tidy up for forms
* fix: Cancel button is a link in the popup
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fibble fibble fibble approved these changes

@hobbyhacker0 hobbyhacker0 hobbyhacker0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wadedvsa @fibble @hobbyhacker0