fix: Prevent previously uploaded evidence from being deleted

[wadedvsa]

Description

Prevent previously uploaded files from being deleted.

Related issue: VOL-3200

Before submitting (or marking as "ready for review")

• Does the pull request title follow the conventional commit specification?
• Have you performed a self-review of the code
• Have you have added tests that prove the fix or feature is effective and working
• Did you make sure to update any documentation relating to this change?

[jerotire]

Nice to see this being addressed. It was a question we raised when doing the CanAccessDocument validator refactor. The DeleteDocument command also uses the same validation (if you can access it, there's a risk you can delete it, even after submission for example). It was proposed a new validator CanDeleteDocument be created, which does the CanAccessDocument checks, but in addition to parsing extra logic (example.. how long ago since upload, is it refering an application/licence in force or under consideration etc...). I am wondering if we think about that in this PR? Or is it too out of scope? @wadedvsa

[jerotire]

Nice to see this being addressed. It was a question we raised when doing the CanAccessDocument validator refactor. The DeleteDocument command also uses the same validation (if you can access it, there's a risk you can delete it, even after submission for example). It was proposed a new validator CanDeleteDocument be created, which does the CanAccessDocument checks, but in addition to parsing extra logic (example.. how long ago since upload, is it refering an application/licence in force or under consideration etc...). I am wondering if we think about that in this PR? Or is it too out of scope? @wadedvsa

CC: @hobbyhacker0

[wadedvsa]

@jerotire I'd say definitely out of scope for this, that sounds like it needs its own dedicated ticket.