Skip to content
This repository has been archived by the owner on Aug 16, 2024. It is now read-only.

fix: remove return type from PeopleController::deleteAction #162

Merged
merged 1 commit into from
May 30, 2024

Conversation

JoshuaLicense
Copy link
Contributor

Description

This is not correct and would need fixing through various levels of inheritance.

Fixes:

TypeError : Olcs\\Controller\\Lva\\Licence\\PeopleController::deleteAction(): Return value must be of type Laminas\\Http\\Response, Laminas\\View\\Model\\ViewModel returned

Related issue: https://dvsa.atlassian.net/browse/VOL-5470

Before submitting (or marking as "ready for review")

  • Does the pull request title follow the conventional commit specification?
  • Have you performed a self-review of the code
  • Have you have added tests that prove the fix or feature is effective and working
  • Did you make sure to update any documentation relating to this change?

This is not correct and would need fixing through various levels of inheritance.
@JoshuaLicense JoshuaLicense self-assigned this May 30, 2024
@JoshuaLicense JoshuaLicense merged commit 398d826 into main May 30, 2024
6 checks passed
@JoshuaLicense JoshuaLicense deleted the fix-incorrect-return-type branch May 30, 2024 11:27
jerotire pushed a commit to dvsa/vol-app that referenced this pull request Aug 16, 2024
…lcs-selfserve#162)

This is not correct and would need fixing through various levels of inheritance.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants