This repository has been archived by the owner on Aug 16, 2024. It is now read-only.
fix: Fix url helper calls in 2 templates #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s call to fromRoute removed. Tested ok.
ilindsay
previously approved these changes
Jan 25, 2024
JoshuaLicense
previously approved these changes
Jan 25, 2024
ilindsay
approved these changes
Jan 26, 2024
JoshuaLicense
approved these changes
Jan 26, 2024
jerotire
pushed a commit
to dvsa/vol-app
that referenced
this pull request
Aug 16, 2024
* fix: Other template fixes where getHelperPluginManager was being used causing errors * fix: Corrects usage of url helper in 2 refactored templates. Erroneous call to fromRoute removed. Tested ok.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Calls url helper method properly in 2 refactored templates.
Related issue: VOL-4874
Before submitting (or marking as "ready for review")