This repository has been archived by the owner on Aug 16, 2024. It is now read-only.
fix: replace laminas-form with patched fork
#33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fibble
previously approved these changes
Jan 26, 2024
fibble
approved these changes
Jan 26, 2024
fibble
approved these changes
Jan 26, 2024
ilindsay
approved these changes
Jan 26, 2024
jerotire
pushed a commit
to dvsa/vol-app
that referenced
this pull request
Aug 16, 2024
* fix: replace `laminas-form` with patched fork * fix: point to `dvsa` fork
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Laminas Form had an issue that was resolved only in v3.9.0 onwards. We use Laminas Form v3.4.x due to PHP version constraints. The fork that this now points to simply cherry-picks that commit until a point we can point back to the latest Laminas form version (PHP upgrade epic).
Related issue: https://dvsa.atlassian.net/browse/VOL-4871