fix(terraform): adjust response_headers_policy_name for CORS requests

[JoshuaLicense]

Description

The VOL app is trying to make a CORS request for the GOV.UK JavaScript. This adjusts the managed policy on CloudFront to pass CORS headers.

[github-actions]

Terraform plan for environment: int

Commit: 33f9d9a

API version: 418eb0c
CLI version: 418eb0c
Selfserve version: 418eb0c
Internal version: 418eb0c

Plan summary

0 to add, 0 to change, 0 to destroy

---

Show full plan

No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.

[github-actions]

Terraform plan for environment: dev

Commit: 33f9d9a

API version: 418eb0c
CLI version: 418eb0c
Selfserve version: 418eb0c
Internal version: 418eb0c

Plan summary

0 to add, 1 to change, 0 to destroy

🔄 Updates

module.service.module.cloudfront.aws_cloudfront_distribution.this[0]

---

Show full plan

Note: Objects have changed outside of Terraform

Terraform detected the following changes made outside of Terraform since the
last "terraform apply" which may have affected this plan:

  # module.service.module.cloudfront.aws_cloudfront_distribution.this[0] has changed
  ~ resource "aws_cloudfront_distribution" "this" {
      ~ etag                            = "E1X62UY4YX24D2" -> "E3HJOLVM7QK4AB"
        id                              = "E3R9S2AKJG4ZTR"
      ~ last_modified_time              = "2024-08-02 10:12:32.531 +0000 UTC" -> "2024-08-02 14:27:16.38 +0000 UTC"
        tags                            = {}
        # (20 unchanged attributes hidden)

        # (6 unchanged blocks hidden)
    }


Unless you have made equivalent changes to your configuration, or ignored the
relevant attributes using ignore_changes, the following plan may include
actions to undo or respond to these changes.

─────────────────────────────────────────────────────────────────────────────

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # module.service.module.cloudfront.aws_cloudfront_distribution.this[0] will be updated in-place
  ~ resource "aws_cloudfront_distribution" "this" {
        id                              = "E3R9S2AKJG4ZTR"
        tags                            = {}
        # (22 unchanged attributes hidden)

      ~ ordered_cache_behavior {
          ~ response_headers_policy_id = "67f7725c-6f97-4210-82d7-5512b31e9d03" -> "eaab4381-ed33-4a86-88ca-d9558dc6cd63"
            # (16 unchanged attributes hidden)

            # (1 unchanged block hidden)
        }

        # (5 unchanged blocks hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.