fix(terraform): increase vcpu of batch compute environment

[matbeales]

Description

Each job is currently set to 1 cpu, and we have many jobs running concurrently so need to compute environment to be significantly more than 4, otherwise jobs will just keep piling up.

We could decrease the cpu of each job in future and maybe lower the VPCU of the compute environment, but this will require more significant testing.

Related issue: https://dvsa.atlassian.net/browse/VOL-5223

Before submitting (or marking as "ready for review")

• Does the pull request title follow the conventional commit specification?
• Have you performed a self-review of the code
• Have you have added tests that prove the fix or feature is effective and working
• Did you make sure to update any documentation relating to this change?

[github-actions]

Terraform plan for environment: dev

Commit: 84faae8

API version: 418eb0c
CLI version: 418eb0c
Selfserve version: 418eb0c
Internal version: 418eb0c

Plan summary

0 to add, 1 to change, 0 to destroy

🔄 Updates

module.service.aws_s3_bucket_policy.bucket_policy

---

Show full plan

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # module.service.aws_s3_bucket_policy.bucket_policy will be updated in-place
  ~ resource "aws_s3_bucket_policy" "bucket_policy" {
        id     = "vol-app-assets"
      ~ policy = jsonencode(
          ~ {
              ~ Statement = [
                  ~ {
                      ~ Condition = {
                          ~ StringEquals = {
                              ~ "aws:SourceArn" = "arn:aws:cloudfront::054614622558:distribution/E1GZYPKGUFNMP4" -> "arn:aws:cloudfront::054614622558:distribution/E3R9S2AKJG4ZTR"
                            }
                        }
                        # (4 unchanged attributes hidden)
                    },
                ]
                # (1 unchanged attribute hidden)
            }
        )
        # (1 unchanged attribute hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

[github-actions]

Terraform plan for environment: int

Commit: 84faae8

API version: 418eb0c
CLI version: 418eb0c
Selfserve version: 418eb0c
Internal version: 418eb0c

Plan summary

0 to add, 1 to change, 0 to destroy

🔄 Updates

module.service.module.batch.aws_batch_compute_environment.this["fargate"]

---

Show full plan

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # module.service.module.batch.aws_batch_compute_environment.this["fargate"] will be updated in-place
  ~ resource "aws_batch_compute_environment" "this" {
        id                              = "vol-app-int-fargate-20240805170600062600000006"
        tags                            = {}
        # (10 unchanged attributes hidden)

      ~ compute_resources {
          ~ max_vcpus           = 4 -> 16
            tags                = {}
            # (13 unchanged attributes hidden)
        }
    }

Plan: 0 to add, 1 to change, 0 to destroy.