Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docker): add internal application Dockerfile #41

Merged
merged 17 commits into from
Apr 22, 2024
Merged

feat(docker): add internal application Dockerfile #41

merged 17 commits into from
Apr 22, 2024

Conversation

rahul-dvsa
Copy link
Contributor

Description

Related issue: VOL-4798

Before submitting (or marking as "ready for review")

  • Does the pull request title follow the conventional commit specification?
  • Have you performed a self-review of the code
  • [] Have you have added tests that prove the fix or feature is effective and working
  • Did you make sure to update any documentation relating to this change?

@rahul-dvsa rahul-dvsa changed the title feat(docker): create productionised application dockerfile for olcs-internal feat(docker): create productionised application dockerfile for olcs internal Mar 19, 2024
@rahul-dvsa rahul-dvsa changed the title feat(docker): create productionised application dockerfile for olcs internal feat(docker): create productionised application dockerfile for olcs internal Mar 19, 2024
JoshuaLicense
JoshuaLicense suggested changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@JoshuaLicense JoshuaLicense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, few minor things

infra/docker/internal/Dockerfile Outdated Show resolved Hide resolved
infra/docker/internal/internal.conf Outdated Show resolved Hide resolved
infra/docker/internal/internal.conf Outdated Show resolved Hide resolved
infra/docker/internal/internal.conf Show resolved Hide resolved
infra/docker/internal/php.ini Outdated Show resolved Hide resolved
JoshuaLicense
JoshuaLicense previously approved these changes Apr 22, 2024
View reviewed changes
@JoshuaLicense JoshuaLicense changed the title feat(docker): create productionised application dockerfile for olcs internal feat(docker): add internal application Dockerfile Apr 22, 2024
@JoshuaLicense JoshuaLicense merged commit ae624a2 into main Apr 22, 2024
23 checks passed
@JoshuaLicense JoshuaLicense deleted the feat/VOL-4798-internal branch April 22, 2024 14:34
@github-actions github-actions bot mentioned this pull request Apr 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awshuss awshuss awshuss left review comments

@JoshuaLicense JoshuaLicense JoshuaLicense approved these changes

@clorro clorro Awaiting requested review from clorro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rahul-dvsa @JoshuaLicense @awshuss