Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(terraform): add CDN infrastructure #80

Merged
merged 6 commits into from
Apr 24, 2024
Merged

feat(terraform): add CDN infrastructure #80

merged 6 commits into from
Apr 24, 2024

Conversation

JoshuaLicense
Copy link
Contributor

Description

More of a proof of concept...

Add a CDN to serve the static assets.

Related issue: https://dvsa.atlassian.net/browse/VOL-5306

Before submitting (or marking as "ready for review")

  • Does the pull request title follow the conventional commit specification?
  • Have you performed a self-review of the code
  • Have you have added tests that prove the fix or feature is effective and working
  • Did you make sure to update any documentation relating to this change?

@JoshuaLicense JoshuaLicense self-assigned this Apr 22, 2024
Copy link
Contributor

github-actions bot commented Apr 22, 2024

Terraform plan for environment: int

Commit: 6efae27

API version: be6a3c6
Selfserve version: be6a3c6
Internal version: be6a3c6

Plan summary

0 to add, 0 to change, 0 to destroy


Show full plan
No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.

Copy link
Contributor

github-actions bot commented Apr 22, 2024

Terraform plan for environment: dev

Commit: 6efae27

API version: be6a3c6
Selfserve version: be6a3c6
Internal version: be6a3c6

Plan summary

0 to add, 1 to change, 0 to destroy

🔄 Updates

module.service.module.cloudfront.aws_cloudfront_distribution.this[0]

Show full plan
Note: Objects have changed outside of Terraform

Terraform detected the following changes made outside of Terraform since the
last "terraform apply" which may have affected this plan:

  # module.service.module.acm.aws_acm_certificate.this[0] has changed
  ~ resource "aws_acm_certificate" "this" {
        id                        = "arn:aws:acm:us-east-1:054614622558:certificate/048d342e-5c72-41c7-b3c4-0bf330cfe440"
      ~ status                    = "PENDING_VALIDATION" -> "ISSUED"
        # (16 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

  # module.service.module.cloudfront.aws_cloudfront_distribution.this[0] has changed
  ~ resource "aws_cloudfront_distribution" "this" {
        id                              = "E3R9S2AKJG4ZTR"
      ~ status                          = "InProgress" -> "Deployed"
        # (21 unchanged attributes hidden)

        # (6 unchanged blocks hidden)
    }


Unless you have made equivalent changes to your configuration, or ignored the
relevant attributes using ignore_changes, the following plan may include
actions to undo or respond to these changes.

─────────────────────────────────────────────────────────────────────────────

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # module.service.module.cloudfront.aws_cloudfront_distribution.this[0] will be updated in-place
  ~ resource "aws_cloudfront_distribution" "this" {
        id                              = "E3R9S2AKJG4ZTR"
        tags                            = {}
        # (22 unchanged attributes hidden)

      - origin {
          - connection_attempts      = 3 -> null
          - connection_timeout       = 10 -> null
          - domain_name              = "vol-app-dev-assets.s3.eu-west-1.amazonaws.com" -> null
          - origin_access_control_id = "E1FW6X81UDPZAI" -> null
          - origin_id                = "s3_oac" -> null
          - origin_path              = "/latest" -> null
        }
      + origin {
          + connection_attempts      = 3
          + connection_timeout       = 10
          + domain_name              = "vol-app-dev-assets.s3.eu-west-1.amazonaws.com"
          + origin_access_control_id = "E1FW6X81UDPZAI"
          + origin_id                = "s3_oac"
          + origin_path              = "/test"
        }

        # (5 unchanged blocks hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

@JoshuaLicense JoshuaLicense marked this pull request as ready for review April 24, 2024 13:43
@JoshuaLicense JoshuaLicense merged commit 74a4dff into main Apr 24, 2024
11 checks passed
@JoshuaLicense JoshuaLicense deleted the add-cdn branch April 24, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant