Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: merge EC2 config with ECS for API #85

Merged
merged 16 commits into from
Apr 26, 2024
Merged

feat: merge EC2 config with ECS for API #85

merged 16 commits into from
Apr 26, 2024

Conversation

gabrielg2020
Copy link
Contributor

@gabrielg2020 gabrielg2020 commented Apr 25, 2024 •
edited
Loading

Merging the EC2 config with the ECS config.

Before submitting (or marking as "ready for review")

  • Does the pull request title follow the conventional commit specification?
  • Have you performed a self-review of the code
  • Have you have added tests that prove the fix or feature is effective and working
  • Did you make sure to update any documentation relating to this change?

@gabrielg2020 gabrielg2020 changed the title feat: Merging EC2 config with ECS for api feat: merging ec2 config with ecs for api Apr 26, 2024
JoshuaLicense
JoshuaLicense suggested changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@JoshuaLicense JoshuaLicense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I could only find a single setting that would be useful to migrate into the new config.

infra/docker/api/php.ini Show resolved Hide resolved
@JoshuaLicense JoshuaLicense marked this pull request as ready for review April 26, 2024 13:13
@JoshuaLicense JoshuaLicense changed the title feat: merging ec2 config with ecs for api feat: merge EC2 config with ECS for API Apr 26, 2024
@JoshuaLicense JoshuaLicense merged commit 2187e98 into main Apr 26, 2024
14 checks passed
@JoshuaLicense JoshuaLicense deleted the merging-EC2-confgit-to-ECS-VOL-5330 branch April 26, 2024 14:57
@github-actions github-actions bot mentioned this pull request Apr 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaLicense JoshuaLicense JoshuaLicense approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gabrielg2020 @JoshuaLicense