Feature/improve error checks for gltf #119

yutopp · 2019-01-08T14:30:26Z

Improve error checks in JsonSchema validators
- Validators check all fields in classes by using EnableDiagnosisForNotRequiredFields = true
  - ref: https://github.com/dwango/UniVRM/pull/119/files#diff-f54ccccba310f47f1fba7508e65437eeR214
- However we can still ignore checks by using ExplicitIgnorableValue attributes
  - ref: https://github.com/dwango/UniVRM/pull/119/files#diff-f54ccccba310f47f1fba7508e65437eeR249
- We can receive notice about values which ware discarded until previous releases
Add tests
Relax default restrictions in JsonSchema for some cases
- Allow strings which is filled by whitespaces
  - null is still disallowed
  - "" and " " are allowed now
    - Use pattern or min/maxLength instead
- Allow empty Array/List
  - null is still disallowed
  - [] is allowed now
    - Use min/maxItems instead

yutopp · 2019-01-09T14:20:15Z

Assets/VRM/UniJSON/Scripts/JsonSchemaValidator/JsonStringValidator.cs

@@ -111,10 +111,6 @@ public JsonSchemaValidationException Validate<T>(JsonSchemaValidationContext c,
            }

            var value = o as string;
-            if (value.All(x => Char.IsWhiteSpace(x)))


json schema allows empty string

null check ?

Thanks, I'll add null checks for all validators.

yutopp · 2019-01-09T14:21:37Z

Assets/VRM/UniJSON/Scripts/JsonSchemaValidator/JsonObjectValidator.cs

-            }
-
-            return null;
+            return GenericValidator<T>.Validate(Required, Properties, c, o);


Check for all fields not only required one.

yutopp · 2019-01-09T14:22:13Z

Assets/VRM/UniJSON/Scripts/FormatterExtensionsSerializer.cs

@@ -47,7 +47,8 @@ public static void SerializeObject(this IFormatter f, object value)
            }
            else
            {
-                typeof(FormatterExtensionsSerializer).GetMethod("Serialize").MakeGenericMethod(value.GetType()).Invoke(null, new object[] { f, value });
+                typeof(FormatterExtensionsSerializer).GetMethod("Serialize")
+                    .MakeGenericMethod(value.GetType()).Invoke(null, new object[] { f, value });


Only add a newline.

yutopp · 2019-01-09T14:22:18Z

Assets/VRM/UniJSON/Scripts/FormatterExtensionsSerializer.cs

@@ -92,7 +93,7 @@ static class GenericSerializer<T>
                var mi = typeof(IFormatter).GetMethod("Value", new Type[] { t });
                if (mi != null)
                {
-                    // premitives
+                    // primitives


yutopp · 2019-01-09T14:23:09Z

Assets/VRM/UniJSON/Scripts/JsonSchemaValidator/JsonArrayValidator.cs

+                return null; // There are no json schema for items, success
+            }
+
+            var v = Items.Validator;


Check items if there is a validator.

saturday06 · 2019-01-09T19:26:41Z

Relax default restrictions in JsonSchema for some cases

Allow strings which is filled by whitespaces

Allow empty Array/List

Please write these exceptions to VRM specification document. When finished, I apply these changes to VRM Validator .

…e checks for validations

…rray/List. Can pass JsonSchemaValidationContext to Serializer optionally

yutopp · 2019-01-11T10:16:08Z

Thank you for your comment. I think that json schema is not affected by this changes. Types of Json schema, string and list([]), requires only not null values as default. Thus current implementation requires extra constraints.
However, if there are some fields which depend on this behaviour, I am going to append constraints explicitly to json schema.

NOTE: Current implementation exclude fields which have empty/containing only whitespaces string and 0-length list.
For example, considering a json string {"name": ""}. Current implementation outputs {} because the value is an empty string. On the other hand, this implementation outputs {"name": ""}.

0b5vr · 2019-01-11T11:45:18Z

GLTF spec requires an item at least per array fields (see below) and it was an improvement of the schema between 1.0 and 2.0 (see below)

GLTF 1.0:

https://github.com/KhronosGroup/glTF/blob/27988cbe931308c7b57bdfae3e4ca9e1a34292e1/specification/1.0/schema/mesh.schema.json#L11-L18

GLTF 2.0:

https://github.com/KhronosGroup/glTF/blob/27988cbe931308c7b57bdfae3e4ca9e1a34292e1/specification/2.0/schema/mesh.schema.json#L8-L15

I know we are not bound to this rule but I think we should follow this way.

yutopp · 2019-01-15T02:16:11Z

Yes, you are right.

Your concerns are cleared. Fields which have constraints like MinItems are not affected by this PR, because it changes only default behaviour of JsonSchema.

yutopp · 2019-01-15T02:37:02Z

Applying changes for glTF/VRM schames will be done by another PR.

yutopp · 2019-01-17T12:22:37Z

Changes for glTF/VRM: #123

yutopp added the WIP label Jan 8, 2019

yutopp force-pushed the feature/improve_error_checks_for_gltf branch from 17164ea to 5361546 Compare January 9, 2019 14:18

yutopp commented Jan 9, 2019

View reviewed changes

yutopp requested a review from ousttrue January 9, 2019 14:25

yutopp removed the WIP label Jan 9, 2019

yutopp added 9 commits January 11, 2019 18:40

Add a test for JsonSchema.Serialize

60041f7

Add an option to check all fields by JsonSchema

317699e

Add/Fix tests for UniJSON. Add ExplicitIgnorableValue option to ignor…

77eaa4b

…e checks for validations

Add null check

cbd158c

Validator checks elements in Array/List. Validator allows Count == 0

4d01aff

Validator allows empty string

12519f2

JsonSchema supports ExplicitIgnorableItemLength to ignore length of A…

eef02f7

…rray/List. Can pass JsonSchemaValidationContext to Serializer optionally

Fix typo. Refactor

32f966e

Fix null errors in JsonArrayValidator

579d533

yutopp force-pushed the feature/improve_error_checks_for_gltf branch from 5361546 to 579d533 Compare January 11, 2019 09:41

ousttrue approved these changes Jan 15, 2019

View reviewed changes

ousttrue merged commit a41617f into master Jan 15, 2019

yutopp deleted the feature/improve_error_checks_for_gltf branch January 15, 2019 10:12

yutopp added this to the v0.49 milestone Jan 17, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/improve error checks for gltf #119

Feature/improve error checks for gltf #119

yutopp commented Jan 8, 2019 •

edited

Loading

yutopp Jan 9, 2019

ousttrue Jan 15, 2019

yutopp Jan 15, 2019

yutopp Jan 9, 2019

yutopp Jan 9, 2019

yutopp Jan 9, 2019

yutopp Jan 9, 2019

saturday06 commented Jan 9, 2019 •

edited

Loading

yutopp commented Jan 11, 2019 •

edited

Loading

0b5vr commented Jan 11, 2019

yutopp commented Jan 15, 2019

yutopp commented Jan 15, 2019

yutopp commented Jan 17, 2019

Feature/improve error checks for gltf #119

Feature/improve error checks for gltf #119

Conversation

yutopp commented Jan 8, 2019 • edited Loading

yutopp Jan 9, 2019

Choose a reason for hiding this comment

ousttrue Jan 15, 2019

Choose a reason for hiding this comment

yutopp Jan 15, 2019

Choose a reason for hiding this comment

yutopp Jan 9, 2019

Choose a reason for hiding this comment

yutopp Jan 9, 2019

Choose a reason for hiding this comment

yutopp Jan 9, 2019

Choose a reason for hiding this comment

yutopp Jan 9, 2019

Choose a reason for hiding this comment

saturday06 commented Jan 9, 2019 • edited Loading

yutopp commented Jan 11, 2019 • edited Loading

0b5vr commented Jan 11, 2019

yutopp commented Jan 15, 2019

yutopp commented Jan 15, 2019

yutopp commented Jan 17, 2019

yutopp commented Jan 8, 2019 •

edited

Loading

saturday06 commented Jan 9, 2019 •

edited

Loading

yutopp commented Jan 11, 2019 •

edited

Loading