Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Component horizontal navigation #593

Open
9 tasks done
htmlandbacon opened this issue Mar 21, 2024 · 5 comments
Open
9 tasks done

Feature: Component horizontal navigation #593

htmlandbacon opened this issue Mar 21, 2024 · 5 comments
Assignees
Labels
🔗 component Reusable parts of the user interface that have been made to support a variety of applications. 🔜 to release Deployable actions from ticket

Comments

@htmlandbacon
Copy link
Member

htmlandbacon commented Mar 21, 2024

What

Review and spec out first version of 'horizontal sub navigation' navigation component for discussion.

Why

We've seen a number of services using sub navigation (in page navigation) along side header navigation to navigate there service

Done when

First thing we need review what we have and pick a version to take forward

  • component spec
  • macro component
  • unit tests
  • sass
  • javascript -(to be reviewed)
  • examples
  • Compatibility testing evidence

Following review the following use cases need to be applied:

  • Additional stacking for mobile
  • JavaScript menu item applied as optional component (review against side navigation and menu item)

Outcomes

A releasable, tested internal service sub navigation.

Review component against others and decide what we might want to extract as a ticket.

Follow up ticket to update guidance on main site.

Related stories

@htmlandbacon htmlandbacon added 🔗 component Reusable parts of the user interface that have been made to support a variety of applications. 🔜 to release Deployable actions from ticket labels Mar 21, 2024
@htmlandbacon htmlandbacon self-assigned this May 9, 2024
@htmlandbacon
Copy link
Member Author

Review session schedule before testing

@htmlandbacon htmlandbacon changed the title Feature: Component internal service sub navigation Feature: Component horizontal navigation May 15, 2024
@htmlandbacon
Copy link
Member Author

When going through this I noticed a couple of parts of the code are now starting to repeat: we might want to consider extracting these out for maintenance/utility reasons.

I've added this as an outcome.

@htmlandbacon
Copy link
Member Author

htmlandbacon commented Jul 31, 2024

To update:

  • Double check and update design branch with mobile version
  • Review and take design layouts into developer branch
  • Confirm additional spacing on mobile version
  • Confirm additional spacing on bottom of the component

To remove to second version branch:

  • Use as header navigation companion
  • Mobile menu functionally

@mitz-lad
Copy link
Collaborator

mitz-lad commented Aug 5, 2024

Reviewed preview site found an issue with mobile link width.

Image

This has been noted to address for mobile and tablet views. All other behaviour and styles as expected for this iteration.

@htmlandbacon
Copy link
Member Author

Will pick up when we do compatibility testing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔗 component Reusable parts of the user interface that have been made to support a variety of applications. 🔜 to release Deployable actions from ticket
Projects
Development

No branches or pull requests

2 participants