Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check in #15

Open
durja opened this issue Dec 29, 2017 · 2 comments
Open

Check in #15

durja opened this issue Dec 29, 2017 · 2 comments

Comments

@durja
Copy link
Contributor

durja commented Dec 29, 2017

Hi,

I am not sure if this was intended in the first place or a typo. I was learning from your article and the first time I ran code coverage on mischief.js, it had a 100% coverage. After scratching my head for sometime, I realized it's doing what the test asked it to do. I had to update the 20000 to number < 10000 to have the right output.

console.log("\nExpect Account1 Opening Balance "+getAccountBalance(account1) +" === 0 \u2713 ");
creditAccount(account1, 2000, 'Add Funds');
transferMoney(account1,account2, 100, 'Give money to friend');
transferMoney(account2,account1, 10, 'Transfer back 10');

@nelsonic
Copy link
Member

@durja thanks for opening this issue! please create a Pull Request to fix it. thanks!

@durja
Copy link
Contributor Author

durja commented Sep 25, 2018

@nelsonic - I have submitted a PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants