Skip to content
This repository has been archived by the owner on Mar 18, 2024. It is now read-only.

feat: added autocomplete, configured oclif settings #1342

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ethan-sargent
Copy link
Contributor

@ethan-sargent ethan-sargent commented Jul 4, 2023

Summary generated by Reviewpad on 04 Jul 23 10:50 UTC

This pull request includes changes to the file package.json. The changes involve adding a dependency, modifying the "oclif" section, and updating the "plugins" array. Please review these changes and ensure their correctness.

Adds autocompletion support to the standalone CLI using @oclif/autocomplete.
The instructions currently have a display bug in the topic separator command. This is caused by @oclif/core installing in the project root, instead of the CLI package.

Checklist

All items have to be completed before a PR is merged

  • Adhere to Contribution Guidelines
  • Updates to Decision Records considered?
  • Updates to documentation at DX@Scale Guide considered?
  • Tested changes?
  • Unit Tests new and existing passing locally?

@reviewpad reviewpad bot added the large Pull request is large label Jul 4, 2023
@ethan-sargent ethan-sargent linked an issue Jul 4, 2023 that may be closed by this pull request
@ethan-sargent ethan-sargent force-pushed the feature/sfpowerscripts-autocomplete branch 2 times, most recently from 7fa4685 to 2b2d711 Compare July 4, 2023 10:48
@ethan-sargent ethan-sargent force-pushed the feature/sfpowerscripts-autocomplete branch from 2b2d711 to e1cf11b Compare July 4, 2023 10:50
@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (5839db4) 47.06% compared to head (873ae9a) 47.06%.

❗ Current head 873ae9a differs from pull request most recent head e1cf11b. Consider uploading reports for the commit e1cf11b to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1342   +/-   ##
=======================================
  Coverage   47.06%   47.06%           
=======================================
  Files          70       70           
  Lines        3096     3096           
  Branches      672      672           
=======================================
  Hits         1457     1457           
  Misses       1496     1496           
  Partials      143      143           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pogilvie
Copy link

still pulling for this

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
large Pull request is large
Projects
None yet
Development

Successfully merging this pull request may close these issues.

standalone CLI shell completion support
2 participants