Skip to content
This repository has been archived by the owner on Mar 18, 2024. It is now read-only.

Deployments do not honor waitTime #1440

Closed
brandonmikeska opened this issue Nov 19, 2023 · 5 comments
Closed

Deployments do not honor waitTime #1440

brandonmikeska opened this issue Nov 19, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@brandonmikeska
Copy link
Contributor

brandonmikeska commented Nov 19, 2023

Describe the bug
While using the release command, it asks for a waitTime but doesn't honor that.

To Reproduce
Steps to reproduce the behavior:
Create a release and put a waitTime other than 2 hours.

Expected behavior
It should take the user's input and use that for the wait time instead of hard coding to 2 hours.

Screenshots
DeploySourceToOrgImpl.ts#L183

Platform Details (please complete the following information):

  • OS: Mac & Windows
  • Version [e.g. CLI Version eg: 1.6.6] Latest
  • Salesforce CLI(sfdx cli) Version: Latest
  • CI Platform: GitHub Actions

Additional context
Add any other context about the problem here.

@github-actions github-actions bot added the analysis To be decided on how to solution/fix label Nov 19, 2023
@azlam-abdulsalam
Copy link
Contributor

Thanks @brandonmikeska , will have a look into it, its the individual package which is timing out isn't it?

@azlam-abdulsalam azlam-abdulsalam added bug Something isn't working and removed analysis To be decided on how to solution/fix labels Nov 19, 2023
@brandonmikeska
Copy link
Contributor Author

@azlam-abdulsalam yes we are working on the team to break up their package into smaller ones as a work around but it's really old legacy test classes taking 2+ hours to run which makes it really difficult for us to deploy at the moment.

@brandonmikeska
Copy link
Contributor Author

Possible fix: #1443

@brandonmikeska
Copy link
Contributor Author

@azlam-abdulsalam do we want to close this out? Also should we build a local docker image until this can be released (November or December release)?

@azlam-abdulsalam
Copy link
Contributor

Yes , its good, will release it next week, you can try the alpha builds to use it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants