This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Use 'xprop' instead of 'wmctrl' to get the window manager. #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 17, 2016 17:29
dylanaraps
added a commit
that referenced
this pull request
Feb 17, 2016
Use 'xprop' instead of 'wmctrl' to get the window manager.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did an strace of
wmctrl -mand it turns out that it gets the windowmanager name from
_NET_WM_NAME. I did some googling and wecan use xprop to get the value of
_NET_WM_NAMEwhich meansthat we can swap the dependency from wmctrl to xprop.
xprop is available almost everywhere which means that users running
X under Mac OS X and Windows will now get the window manager info
too!
I'm currently going through VMs testing this change but it seems like
it should work anyway.