Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/sequencers: bond reduction min bond check remove callsites #1064

Closed
Tracked by #1055
danwt opened this issue Aug 9, 2024 · 1 comment
Closed
Tracked by #1055

x/sequencers: bond reduction min bond check remove callsites #1064

danwt opened this issue Aug 9, 2024 · 1 comment

Comments

@danwt
Copy link
Contributor

danwt commented Aug 9, 2024

The min bond is checked at the initial Msg step, but then it's also checked at the maturity

It should only happen once

@spoo-bar
Copy link
Contributor

It is checked during the MsgDecreaseBond just to fail early incase the seq wants to reduce too much
It is checked during the actual reduction as its possible that the minbond value has increased by then.

I think its critical to keep the check during maturity. But removing it from the Msg would mean a seq might request too high reduction amount but not know why they didnt get as much back 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants