Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/sequencers: check IsAllLT coins usages in unbond logic #1070

Closed
Tracked by #1055
danwt opened this issue Aug 9, 2024 · 0 comments · Fixed by #1136
Closed
Tracked by #1055

x/sequencers: check IsAllLT coins usages in unbond logic #1070

danwt opened this issue Aug 9, 2024 · 0 comments · Fixed by #1136
Assignees
@spoo-bar

Comments

@danwt
Copy link
Contributor

danwt commented Aug 9, 2024

For example

dymension/x/sequencer/keeper/unbond.go

Line 168 in acd9d13

if newBalance.IsAllLT(sdk.NewCoins(minBond)) {

Needs to be double checked if they should be IsAnyLT instead
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spoo-bar spoo-bar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: change the coins compare in bond reduction to compare the amounts dymensionxyz/dymension
2 participants
@spoo-bar @danwt