Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slash should not burn non-dym #1262

Closed
danwt opened this issue Sep 25, 2024 · 3 comments
Closed

Slash should not burn non-dym #1262

danwt opened this issue Sep 25, 2024 · 3 comments
Labels

Comments

@danwt
Copy link
Contributor

danwt commented Sep 25, 2024

In x/sequencer/keeper/unbond.go:77, the Hub logic handles the bond of jailed sequencers by burning them.
While this is working as designed if the bond is denominated only in DYM, this may not always be the case; for example, if the bond is partly made of IBC tokens, these tokens may require the burn to happen in their source chain.
Recommendation
We recommend changing the jailing logic to seize tokens in favor of a trusted treasury address instead of burning them.

@danwt danwt added the security label Sep 25, 2024
@omritoptix
Copy link
Contributor

min bond is a param. we can assume it's always DYM for the time being. so I'm not gonna close this issue but it's not for 3D.

@danwt danwt closed this as completed Oct 16, 2024
@danwt danwt reopened this Oct 16, 2024
@danwt danwt changed the title Jailed sequencer’s bond is always burned Slash should not burn non-dym Oct 16, 2024
@mtsitrin
Copy link
Contributor

mtsitrin commented Oct 20, 2024

Sequencer bond is currently enforced to be single denom (DYM) (#1292)

@danwt
Copy link
Contributor Author

danwt commented Oct 21, 2024

Thanks @mtsitrin , closing

@danwt danwt closed this as completed Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants