Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rollapp] packet/states in store should be prefixed with rollappId as well #631

Open
mtsitrin opened this issue Mar 6, 2024 · 0 comments · May be fixed by #1390
Open

[rollapp] packet/states in store should be prefixed with rollappId as well #631

mtsitrin opened this issue Mar 6, 2024 · 0 comments · May be fixed by #1390
Assignees
@keruch
Labels
c:rollapp Rollapp module

Comments

@mtsitrin
Copy link
Contributor

mtsitrin commented Mar 6, 2024 •
edited
Loading

currently, BlockHeightToFinalizationQueue prefixed with creation_height and holds unsorted array of stateIdx

The queue should be prefixed by height/rollappId, so all the pending of a specific rollapp can be queried easily

It also applies to the DelayedAck middleware
@mtsitrin mtsitrin added the c:rollapp Rollapp module label Mar 6, 2024
@mtsitrin mtsitrin mentioned this issue Mar 17, 2024
Closed
@mtsitrin mtsitrin changed the title [rollapp] finalizationQueue should be prefixed with rollappId as well [rollapp] packet/states in store should be prefixed with rollappId as well Mar 19, 2024
@mtsitrin mtsitrin mentioned this issue Mar 19, 2024
Merged
29 tasks
@mtsitrin mtsitrin mentioned this issue Oct 30, 2024
Open
@omritoptix omritoptix assigned mtsitrin and keruch and unassigned anhductn2001 and mtsitrin Nov 2, 2024
@keruch keruch linked a pull request Nov 5, 2024 that will close this issue
Open
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@keruch keruch

Labels
c:rollapp Rollapp module
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(rollapp): prefixed finalization queue with rollappID dymensionxyz/dymension
3 participants
@keruch @anhductn2001 @mtsitrin