Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of kaleidoscope filter #174

Closed
gbendy opened this issue Jul 5, 2023 · 6 comments
Closed

Lack of kaleidoscope filter #174

gbendy opened this issue Jul 5, 2023 · 6 comments

Comments

@gbendy
Copy link
Contributor

gbendy commented Jul 5, 2023

Would you be open to a PR to add my kaleid0sc0pe filter to the core codebase?

https://github.com/gbendy/kaleidoscope/

@jaromil
Copy link
Member

jaromil commented Jul 6, 2023

@gbendy you are welcome! is there a way to build it without SSE specific instructions?

@gbendy
Copy link
Contributor Author

gbendy commented Jul 6, 2023

Yes, there's a CMake option. Can default that to off. Or can just make it rely on the __SSE2__ define that other filters like aech0r/colgate/medians use,

BTW, I got it building in the frei0r codebase today. Just haven't tested the output yet.

@jaromil
Copy link
Member

jaromil commented Jul 6, 2023

@gbendy excellent, will follow up on the PR

@jaromil
Copy link
Member

jaromil commented Aug 5, 2023

dears, any clues about this? rdp/ffmpeg-windows-build-helpers#706 I am not an expert of latest C++ stuff nor Win64 platform, so worst case scenario I'd skip build for that platform but it's a pity

@gbendy
Copy link
Contributor Author

gbendy commented Aug 6, 2023

Cross compiler configuration related. Can detect and deal with the problem at cmake time #179

@gbendy
Copy link
Contributor Author

gbendy commented Aug 6, 2023

All works fine if you build in native Win64. Seems so bizarre that even now some C++11 features aren't supported in some compiler setups.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants