Fix link bug in insnCodeGen::loadImmIntoReg on aarch64 #1405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function template has a separate declaration and "definition" AND is called from translation units where neither is located. This only happens to work correctly when the TUs are linked in a specific order.
The value is now always positive.
|
@kupsch This is now building on Zeroah. Now running test suite. |
kupsch
approved these changes
Apr 3, 2023
| return; | ||
| } | ||
| else { | ||
| restoreGPRtoGPR(gen, ra, dest); | ||
| } | ||
| } else { | ||
| insnCodeGen::loadImmIntoReg<long int>(gen, dest, 0); | ||
| insnCodeGen::loadImmIntoReg(gen, dest, static_cast<Address>(0)); |
There was a problem hiding this comment.
Agreed, but I was trying to make it more obvious what was happening at the callsite since the template parameter should have been an Address. I guess I could have used Address{0}, but I'm going to say it's still better than what was there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function template has a separate declaration and "definition" AND is called from translation units where neither is located. This only happens to work correctly when the TUs are linked in a specific order.