Add new Symtab interface for accessing modules by offset #1545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is replaced by findModuleByOffset(Offset).
It was never documented and makes no sense as offsets are unique within a module (i.e., DWARF CU). Further, Dyninst uses a separate Symtab instance for each object file in an archive.
hainest
added
code cleanup
kupsch
approved these changes
Sep 29, 2023
jmellorcrummey
pushed a commit
to HPCToolkit/hpctoolkit
that referenced
this pull request
Oct 23, 2023
for finding the Module that contains a given address. This was a hard switch in Dyninst (no overlap), so add a configure test for which method exists in dyninst. This MR supersedes !940 for adapting hpcstruct to the new Dyninst. See also: dyninst/dyninst#1545 dyninst/dyninst#1571
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add findModuleByOffset(Offset)
Deprecate findModuleByOffset(Module *&, Offset)
It is replaced by findModuleByOffset(Offset).
Remove findModuleByOffset(std::set<Module *>&, Offset)
It was never documented and makes no sense as offsets are unique
within a module (i.e., DWARF CU). Dyninst uses a separate
Symtab instance for each object file in an archive, as well.