Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opcode suffixes do not take into account prefix bytes #198

Closed
nathanhjay opened this issue Oct 14, 2016 · 0 comments
Closed

Opcode suffixes do not take into account prefix bytes #198

nathanhjay opened this issue Oct 14, 2016 · 0 comments
Assignees

Comments

@nathanhjay
Copy link
Contributor

I think we're not changing the suffix of sbb when it is prefixed.

On sbb, we use the 'l' prefix with %rax. The l-prefix should only be used for 64 bits in the case of floating point instructions, according to the rules imposed by gas.
Bytes: 4a 83 d8 f4
Dyninst Output: sbbl $0xfffffffffffffff4,%rax

We also use the 'l' prefix with %bp for sbb, which isn't correct.
Bytes: 66 83 dd c0
Dyninst Output: sbbl $0xc0,%bp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants