Fix proccontrol hangs in test_thread_X #780

hainest · 2020-07-24T20:59:01Z

This cleans up handling of events from the mailbox (event queue) used to communicate between Dyninst and proccontrol.

This is rebased on #742
Closes #741

This makes it symmetric with the check when dequeueing.

This will help reduce spurious wakeups.

This should not happen, but it's a good sanity check.

This replaces manual locking/unlocking of the mutex.

This just saves hitting the queue if we are blocking.

This prevents most vexxing parse confusion when reading the code.

** REMOVE before commiting PR **

This prevents accidental insertion of non-existent keys.

This prevents null pointer issues as well as pointer-reuse in some abnormal situations.

* pcEventMuxer: Fix print specifier in debug logging This should have been fixed in 6bd68f3 * Simplify PCEventMailbox::size * Make PCEventMailbox::find threadsafe * Whitespace update * Add more logging for state handling

hainest added bug test suite These changes are needed to correct or improve a test in the Testsuite. labels Jul 24, 2020

hainest added this to the Release 10.2 milestone Jul 24, 2020

hainest self-assigned this Jul 24, 2020

hainest added 26 commits July 24, 2020 16:22

Check process before enqueueing in PCEventMailbox

f6afd71

This makes it symmetric with the check when dequeueing.

Add more proccontrol logging in PCEventMailbox

c48e4ef

Remove unused includes

70cefeb

Handle errors for Process::handleEvents in PCEventMuxer::wait_internal

b42000a

Add logging for mailbox size check in PCEventMuxer::wait_internal

2cc54cd

Add more loggin in non-blocking path of PCEventMuxer::wait_internal

c9b64d9

Add logging for 'handle(NULL)' call in PCEventMuxer::wait_internal

7424590

Log successful event completion in PCEventMuxer::wait_internal

4f3b6dd

Remove unreachable code in PCEventMuxer::wait_internal

518b672

Remove unused parameter in PCEventMuxer::handle_internal

ce96532

Use std::lock_guard in PCEventMailbox::enqueue

de25adf

Move broadcast to the end of PCEventMailbox::enqueue

f9f8970

This will help reduce spurious wakeups.

PCEventMailbox::enqueue: only add events for valid processes

3645bf5

This should not happen, but it's a good sanity check.

Use std::lock_guard in PCEventMailbox::dequeue

fa53d57

This replaces manual locking/unlocking of the mutex.

Reverse order of check for empty queue when not blocking

cdda742

This just saves hitting the queue if we are blocking.

Use braced-initializer when returning empty event

61b2e4d

This prevents most vexxing parse confusion when reading the code.

PCEventMailbox::dequeue: add logging when returning empty event

b988541

PCEventMailbox::dequeue: comment algorithmic procedure

52c871b

PCEventMailbox::dequeue: Add sanity check for process pointer

db3dedf

PCEventMailbox::dequeue: add logging on sucessful event dequeue

ee239f7

Add debugging in mailbox endqueue/dequeue

bf87be6

** REMOVE before commiting PR **

PCEventMailbox::find: Use standard check for element values

239565c

This prevents accidental insertion of non-existent keys.

PCEventMailbox::find: add logging

4361ba2

PCEventMailbox::find: add sanity check for passed process

f1a811a

PCEventMailbox::dequeue: Ignore post-exit events on invalid processes

c11cf30

PCEventMailbox: Change procCount to map PIDs instead of PCProcess*

107cd99

This prevents null pointer issues as well as pointer-reuse in some abnormal situations.

hainest merged commit 6bd68f3 into dyninst:master Jul 24, 2020

hainest deleted the eventmailbox_fix branch July 24, 2020 21:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix proccontrol hangs in test_thread_X #780

Fix proccontrol hangs in test_thread_X #780

hainest commented Jul 24, 2020 •

edited

Loading

Fix proccontrol hangs in test_thread_X #780

Fix proccontrol hangs in test_thread_X #780

Conversation

hainest commented Jul 24, 2020 • edited Loading

hainest commented Jul 24, 2020 •

edited

Loading