Correctly destruct AddressSpace objects #871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was originally part of #317.
hainest
added
bug
code cleanup
|
https://bottle.cs.wisc.edu/search?dyninst_branch=PR871 No regressions (cori@NERSC is offline right now). |
mxz297
approved these changes
Oct 1, 2020
|
@hainest Looks good. I don't think this memory leak fix will make much difference as AddressSpace objects do not get destructed. But this is still good to fix. |
Yikes. I did some digging and found that there are circular lifetimes between |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deleteAddressSpaceis still highly suspect because its only use iscopyAddressSpacewhich doesn't fully copy the object. However, this fix at least makesdeleteAddressSpaceand~AddressSpacecorrect and perform the same actions.This was originally part of #317.