Fixing another bug related to amdgpu register names #948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…egid for registers of different type common/h/amdgpu_vega_sys_regs.h
…ividual registers
hainest
requested changes
Jan 20, 2021
hainest
added
GPUs
hainest
approved these changes
Jan 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So in one of the previous commits,
the header file common/h/amdgpu_vega_sys_reg.h is polluted with wrong mapping
So incorrect register name will be reported for amdgpu and registers with higher register id might not be identified correctly.
modification made to dyn_regs.C/name function is to account for cases when the register id mapping doesn't start from 0, in which case we want to make sure we use the relative offset from the base registers.