This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
Swift 3 Support #62
Merged
Swift 3 Support #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
November 26, 2016 22:16
… for Swift 3 compatibility + Adjusts sample's implementation and tests'
Current coverage is 91.18% (diff: 84.62%)
|
added 2 commits
November 27, 2016 23:08
* Documented the original playground prototype Added a new playground for designing the librarie's repo header * Completes the Iconic header's layout, done in playgrounds * Tweaks the Iconic header view's style/appearance * Adds temp header view. All done with Playgrounds * Updates Iconic to be using AwesomeFont 4.7.0 as default font. Updated failing tests due to visual regressions. * Modularizes the Iconic header design playground, simplifying it a lot * Design tweaks and updates header render * Typo * Fixing code syntax
dzenbot
force-pushed
the
swift-3-support
branch
from
08c3e7f
to
4acf5e2
Compare
Generated by 🚫 danger |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #56
After all, there was no need to update SwiftGen, but only the stencil (aka template). This is because the SwiftGen executale is already compiled and versioned on this repo, which makes things much more easier. We used to compile SwiftGen at every
pod install, but this was causing issues at times and it was failing when using the newest Swift compilers. The SwiftGen fork will eventually need to be updated/fixed, and ported to a newer Swift version (but let's not worry about that just yet).Since Swift 3, enum cases have changed, moving from UpperCamelCase to lowerCamelCase. This has been reflected in the SwiftGen stencil, although was causing issues with reserved types such as
subscript,repeat,open, etc. To solve this issue, Iconic enum cases now append aIconbit, to make sure types are unique and not conflicting. This is also reflected in the icon catalog builder.Finally, since Swift 2.3 will soon be deprecated with the release of Xcode 8.2 there is no point of adding backwards compatibility to Iconic for those still using Swift 2.3