Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAN data overflow (speed signal) #8

Open
dzid26 opened this issue Mar 26, 2023 · 1 comment
Open

CAN data overflow (speed signal) #8

dzid26 opened this issue Mar 26, 2023 · 1 comment
Labels
good first issue Good for newcomers

Comments

@dzid26
Copy link
Owner

dzid26 commented Mar 26, 2023

None of the conversions from float to int is protected.

int8_t Msg_steering_status_steering_speed_encode(float value)
{
return (int8_t)(value / 0.015625f);
}
This ideally should be done by fixing cantools.
image
This happens at high speed with no load.

@dzid26
Copy link
Owner Author

dzid26 commented Jun 8, 2023

Let's either hack it (limit the speed to something below limit from DBC) or modify cantools submodule.

@dzid26 dzid26 added the good first issue Good for newcomers label Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant