Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vulnerable to XSS #36

Closed
ngyikp opened this issue Jun 1, 2020 · 2 comments
Closed

Vulnerable to XSS #36

ngyikp opened this issue Jun 1, 2020 · 2 comments
Labels
Bug

Comments

@ngyikp
Copy link
Contributor

ngyikp commented Jun 1, 2020

Inspired by https://twitter.com/_r3ggi/status/1265629984753844225

I did a quick check with <img src=1 onerror=document.documentElement.textContent=window.location>.ipa and looks like the XSS works:
@ealeksandrov
Copy link
Owner

image

Looks like it's already resolved by Apple? I'm on macOS 10.15.6.

@ealeksandrov
Copy link
Owner

I managed to find machine with macOS 10.15.4, reproduce and fix this issue 🙂
Fix applied in f8c75d8 - add XML escaping for file name.
Released as 1.6.2.

macOS 10.15.4, ProvisionQL 1.6.1:
before

macOS 10.15.4, ProvisionQL 1.6.2:
after

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ealeksandrov @ngyikp