From c710b6172ea0aac9d9a18b2dd43b0948624d71a6 Mon Sep 17 00:00:00 2001 From: Eduardo Apolinario <653394+eapolinario@users.noreply.github.com> Date: Wed, 2 Mar 2022 23:13:31 -0800 Subject: [PATCH] Parametrize functional test (#55) Signed-off-by: Eduardo Apolinario Co-authored-by: Eduardo Apolinario --- boilerplate-repo/boilerplate/flyte/end2end/Makefile | 7 ++++--- boilerplate-repo/boilerplate/flyte/end2end/end2end.sh | 5 ++++- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/boilerplate-repo/boilerplate/flyte/end2end/Makefile b/boilerplate-repo/boilerplate/flyte/end2end/Makefile index b0eb945b13..7f080e9502 100644 --- a/boilerplate-repo/boilerplate/flyte/end2end/Makefile +++ b/boilerplate-repo/boilerplate/flyte/end2end/Makefile @@ -5,8 +5,9 @@ .PHONY: end2end_execute end2end_execute: - ./boilerplate/flyte/end2end/end2end.sh - + # TODO: These arguments could come from environment variables + ./boilerplate/flyte/end2end/end2end.sh ./boilerplate/flyte/end2end/functional-test.config --return_non_zero_on_failure + .PHONY: k8s_integration_execute k8s_integration_execute: - echo "pass" \ No newline at end of file + echo "pass" diff --git a/boilerplate-repo/boilerplate/flyte/end2end/end2end.sh b/boilerplate-repo/boilerplate/flyte/end2end/end2end.sh index fd53e2598c..4dae992316 100755 --- a/boilerplate-repo/boilerplate/flyte/end2end/end2end.sh +++ b/boilerplate-repo/boilerplate/flyte/end2end/end2end.sh @@ -6,8 +6,11 @@ # TO OPT OUT OF UPDATES, SEE https://github.com/flyteorg/boilerplate/blob/master/Readme.rst set -e +CONFIG_FILE=$1; shift +EXTRA_FLAGS=( "$@" ) + DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null && pwd )" LATEST_VERSION=$(curl --silent "https://api.github.com/repos/flyteorg/flytesnacks/releases/latest" | jq -r .tag_name) -FLYTE_SDK_USE_STRUCTURED_DATASET=TRUE python ./boilerplate/flyte/end2end/run-tests.py $LATEST_VERSION P0,P1 ./boilerplate/flyte/end2end/functional-test.config --return_non_zero_on_failure +FLYTE_SDK_USE_STRUCTURED_DATASET=TRUE python ./boilerplate/flyte/end2end/run-tests.py $LATEST_VERSION P0,P1 $CONFIG_FILE ${EXTRA_FLAGS[@]}