Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cinn25519 shortname encoding is incorrect #354

Open
sgwilym opened this issue Jul 14, 2024 · 0 comments
Open

Cinn25519 shortname encoding is incorrect #354

sgwilym opened this issue Jul 14, 2024 · 0 comments
Labels
willow Issues with the willow branch.

Comments

@sgwilym
Copy link
Contributor

sgwilym commented Jul 14, 2024

What's the problem you want solved?

The current Cinn25519 encoding appends 0x0 to an encoded shortname only if shortname.length < max_length. This is wrong.

Is there a solution you'd like to recommend?

The encoded shortname should append 0x0 whenever min_length < max_length, regardless of shortname length.
@sgwilym sgwilym added the willow Issues with the willow branch. label Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
willow Issues with the willow branch.
Projects
earthstar-js v11 Release
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sgwilym