Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installing extensions from git repository #3251

Closed
jotelha opened this issue Mar 21, 2020 · 2 comments · Fixed by #3294
Closed

Installing extensions from git repository #3251

jotelha opened this issue Mar 21, 2020 · 2 comments · Fixed by #3294
Milestone

Comments

@jotelha
Copy link

jotelha commented Mar 21, 2020

Usually, it is possible to install from a git repository directly, and without looking at the mechanisms in too much detail, I believe that this works by providing git_config at

path = self.obtain_file(filename, download_filename=download_filename, force_download=force_download,

However, I was not able to figure out how to do the same for an extension (defined within the exts_list easyconfig parameter), and I suspect that might be due to the fact that no git_config from an extension's options is passed at

src_fn = self.obtain_file(fn, extension=True, urls=source_urls, force_download=force_download)

Why not? Wouldn't that be useful, i.e. for installing a custom python repository via git together with its dependencies (say, standard pipy packages) in a PythonBundle?

@boegel boegel added this to the 4.x milestone Apr 11, 2020
@boegel
Copy link
Member

boegel commented Apr 11, 2020

@jotelha Building extensions straight from a Git repository is currently not supported, and yes this would be useful.

For extensions, the way to specify which source to use is a bit crippled: all you can use is source_tmpl, as opposed to sources for non-extensions (where you can use git_config, see https://easybuild.readthedocs.io/en/latest/Writing_easyconfig_files.html#downloading-from-a-git-repository).

The easiest way to ensure you can use git_config for extensions is probably to make sure that sources is picked up for extensions (and then probably deprecate the custom source_tmpl which only works for extensions)...

@boegel
Copy link
Member

boegel commented May 2, 2020

Relevant recent PR by @kelseymh: #3294

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants