Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve search context feature #319

Merged
merged 3 commits into from
Feb 16, 2023

Conversation

aericson
Copy link
Contributor

This PR builds on the feature built on #279. It improves the UI and add a new option useAllContextsWithNoSearchContext.

  1. useAllContextsWithNoSearchContext
    Adds an option that is off by default. The indexes from all contexts will also be present on the default index. This is to allow searching on every index. Using this option together with searchContextByPaths allows context and global searches.
  2. Improvements to the the context UI by:
    • Displaying an indicator on the search bar when the using a specific context
      Screenshot 2023-02-10 at 13 48 43
    • Add a select to search by context on the search page
      Screenshot 2023-02-10 at 13 48 15

The following new strings are added and will need to be added to the translation files:

  • theme.SearchBar.searchInContext
  • theme.SearchPage.searchContext.everywhere

@netlify
Copy link

netlify bot commented Feb 10, 2023

Deploy Preview for easyops-cn-docusaurus-search-local ready!

Name Link
🔨 Latest commit c8b9175
🔍 Latest deploy log https://app.netlify.com/sites/easyops-cn-docusaurus-search-local/deploys/63e65a4942e4870008e4598b
😎 Deploy Preview https://deploy-preview-319--easyops-cn-docusaurus-search-local.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@aericson aericson marked this pull request as ready for review February 10, 2023 14:58
@aericson
Copy link
Contributor Author

@weareoutman can you take a look when you have some spare time? 😄

@weareoutman
Copy link
Member

@aericson Thanks for you contribution, this seems great!

However, I got very busy these weeks, I'll try to look into it later.

@aericson
Copy link
Contributor Author

@aericson Thanks for you contribution, this seems great!

However, I got very busy these weeks, I'll try to look into it later.

Take your time, just wanted to get it in your radar in case you haven't seen it.

@weareoutman weareoutman merged commit d3a407b into easyops-cn:master Feb 16, 2023
weareoutman added a commit that referenced this pull request Feb 16, 2023
Trigger a release action only
@weareoutman
Copy link
Member

Thanks again, release in 0.34.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants