Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: append a / to the search link #432

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

aduros
Copy link
Contributor

@aduros aduros commented Jul 8, 2024

Thanks for this plugin!

Most hosting providers HTTP redirect mysite.com/docs/search?q=test to mysite.com/docs/search/?q=test... except S3 which tosses out the query string and redirects to mysite.com/docs/search/.

Rather than relying on the backend redirect to work, tweak the link here on the frontend to already contain the slash suffixed path.

Most hosting providers HTTP redirect `mysite.com/docs/search?q=test` to `mysite.com/docs/search/?q=test`... except S3 which tosses out the query string and redirects to `mysite.com/docs/search/`.

Rather than relying on the backend redirect to work, tweak the link here on the frontend to already contain the slash suffixed path.
Copy link

netlify bot commented Jul 8, 2024

Deploy Preview for easyops-cn-docusaurus-search-local ready!

Name Link
🔨 Latest commit 89f968e
🔍 Latest deploy log https://app.netlify.com/sites/easyops-cn-docusaurus-search-local/deploys/668bbdf0cca7010007bc13c6
😎 Deploy Preview https://deploy-preview-432--easyops-cn-docusaurus-search-local.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@weareoutman weareoutman disabled auto-merge July 8, 2024 10:49
@weareoutman weareoutman enabled auto-merge (squash) July 8, 2024 10:50
@weareoutman
Copy link
Member

Thanks for your contribution.

@weareoutman weareoutman merged commit 60c23d4 into easyops-cn:master Jul 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants