Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct linking to measures from email alerts is broken #4588

Open
sebbacon opened this issue Jan 24, 2024 · 1 comment
Open

Direct linking to measures from email alerts is broken #4588

sebbacon opened this issue Jan 24, 2024 · 1 comment

Comments

@sebbacon
Copy link
Contributor

A link like this (https://openprescribing.net/practice/J81010/measures/?tags=cost#lpherbal) (note the anchor fragment) is configured to scroll to the measure and highlight it, like this:

image

However, this doesn't usually work when linked from the email alerts. Here's an example link from an alert:

https://openprescribing.net/practice/J81010/measures/?utm_medium=email&utm_campaign=monthly+alert+2024-01-23&utm_source=dashboard-alerts&utm_content=%2Femail%2Fmonthly+alert+2024-01-23%2Fdashboard-alerts%2F1502#lpherbal

(in passing, I think we don't use google analytics any more? So those tracking tags are redundant?)

@evansd
Copy link
Collaborator

evansd commented Jan 29, 2024

I don't think the issue here is quite as described. The problem is that the specified measure does not appear on the linked page.

Possibly this is because it is not tagged as a "core" measure?

"tags": [
"cost",
"efficacy",
"lowpriority"
],

I thought that only "core" measures got included in email alerts, but maybe I've misunderstood/misremembered.

Changing the specified measure to one that does exist on the page demonstrates that the measure highlighting works even in the presence of the UTM parameters:
https://openprescribing.net/practice/J81010/measures/?utm_medium=email&utm_campaign=monthly+alert+2024-01-23&utm_source=dashboard-alerts&utm_content=%2Femail%2Fmonthly+alert+2024-01-23%2Fdashboard-alerts%2F1502#statinintensity

Regarding what we currently use for stats, I think we're using both Google Analytics and Plausible. Certainly we're still loading the GA javascript.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants