Added TELEMAC Notebook and files #93
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomsail
commented
May 31, 2024
| @@ -59,6 +59,7 @@ def _resolve_ranges(x_range: tuple[float, float] | None, y_range: tuple[float, f | |||
| def open_dataset( | |||
| path: str | os.PathLike[str], | |||
| normalize: bool = True, | |||
| source_crs: int = 4326, | |||
There was a problem hiding this comment.
I guess we shouldn't force on the int type here, but I didn't know how to do that.
I don't if we can use pyproj inside (and also for the typing types)
tomsail
commented
May 31, 2024
| @@ -227,7 +227,7 @@ def normalize_adcirc(ds: xarray.Dataset) -> xarray.Dataset: | |||
| } | |||
|
|
|||
|
|
|||
| def normalize(ds: xarray.Dataset) -> xarray.Dataset: | |||
| def normalize(ds: xarray.Dataset, source_crs: int = 4326) -> xarray.Dataset: | |||
There was a problem hiding this comment.
same here for the int type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main new feature added:
normalize.pyandopen_dataset)Added tests (with Selafin files) for:
Bumped up the limit file size in pre-commit
(added jupyter-bokeh in the dev deps too)