Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to search functionality in the website #2858

Closed
ac10n opened this issue Mar 6, 2024 · 2 comments · Fixed by #2866
Closed

Improvements to search functionality in the website #2858

ac10n opened this issue Mar 6, 2024 · 2 comments · Fixed by #2866
Assignees
Labels
ux/dx Related to Developer Experience

Comments

@ac10n
Copy link
Contributor

ac10n commented Mar 6, 2024

Currently, I observe these search related problems. These can affect a user trying to find information.
The information I'm trying to find is: RemoteSigner.

  1. When going to the website, in home page, the search functionality returns nothing
  2. In docs, in any version other than the currently latest version, the search functionality returns nothing
  3. When in the current version, the most relevant result is not shown in the first page, and then when clicking on the "See all 11 results":
  4. We are taken to a page with Dropbox for version, where the item is on "next", so the search returns nothing.

As a user, I could not guess changing the version fixes this.

Also, searching in Google for RemoteSigner site:tezostaquito.io does not return the "Class RemoteSigner" in the first page of results

@ac10n ac10n added the ux/dx Related to Developer Experience label Mar 6, 2024
@ac10n ac10n self-assigned this Mar 6, 2024
@ac10n
Copy link
Contributor Author

ac10n commented Mar 12, 2024

The current experience:

SearchExperience.mp4

@ac10n
Copy link
Contributor Author

ac10n commented Mar 12, 2024

It seems to be a known issue that the search page does not respect the DocSearch options, so while turning the contextualSearch off changes the behaviour of the search modal, it does not affect the search page.

I swizzled the search page. In a separate commit, I modified it to respect the option.
After merging, and verifying that the search works properly, it might be fixed for the searchpage as well, because a re-index with contextualSearch:off will fix that, according to the linked issue.

In that case, we can do a separate PR to undo the swizzling of the SearchPage, which is a good idea, as it reduces the code we need to maintain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ux/dx Related to Developer Experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant