Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct reference when adding thumbnail images #263

Conversation

andreas-schilling
Copy link
Contributor

fix #256

@FrankSchnicke
Copy link
Contributor

Thanks a lot for providing this PR! I see that there are lots of changes in the AASXSerializerTest.java, most likely due to a auto formatter.
Would it be possible to update this file to only show the real changes?

@andreas-schilling
Copy link
Contributor Author

Sorry, yes. Will do.
Btw, do you have an official formatter configuration to share?

@FrankSchnicke
Copy link
Contributor

FrankSchnicke commented Mar 14, 2024

Btw, do you have an official formatter configuration to share?

Not as of today but this is a valid point. I opened an issue and we will discuss it in the Committer & PL round.

Thank you very much for your contribution!

@FrankSchnicke FrankSchnicke merged commit 429da95 into eclipse-aas4j:main Mar 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Thumbnail images are not properly referenced when writing AASX files
2 participants