You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
is an instance of a single ClangdProjectService class. Exposing this as the root API means it is not possible to expose other features without adding them to the ClangdProjectService itself, creating a very ugly interface.
For example, this PR: clangd#575 is exposing access to the AST and wont play nicely with the changes in this fork.
Could you consider changing the exports to be more extensible, possibly employing the same versioned API in the PR mentioned above?
The text was updated successfully, but these errors were encountered:
thanks for raising this. We are all in favor of adopting the exports to allow a more extensible API.
However, I would like to wait with this until clangd#575 is merged in the upstream project.
Then we can make the necessary changes in combination with an update to the latest upstream version.
Ah I wasn't aware that there already was an ongoing discussion about this.
In that case, we are happy to take this over and adapt your extension API to align it with the API mentioned in the PR.
The exported API here: https://github.com/eclipse-cdt-cloud/vscode-clangd/blob/main/src/extension.ts#L18
is an instance of a single
ClangdProjectService
class. Exposing this as the root API means it is not possible to expose other features without adding them to theClangdProjectService
itself, creating a very ugly interface.For example, this PR: clangd#575 is exposing access to the AST and wont play nicely with the changes in this fork.
Could you consider changing the exports to be more extensible, possibly employing the same versioned API in the PR mentioned above?
The text was updated successfully, but these errors were encountered: