Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Vertx Devfile and use official sample project #13641

Closed
sleshchenko opened this issue Jun 27, 2019 · 1 comment
Closed

Improve Vertx Devfile and use official sample project #13641

sleshchenko opened this issue Jun 27, 2019 · 1 comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@sleshchenko
Copy link
Member

sleshchenko commented Jun 27, 2019

Description

This issue is created as a consequence to a discussion here eclipse-che/che-devfile-registry#18 (comment)

Current Vertx Devfile is actually adapted Stack and sample that we used to use by in Devfile format.
There was a try to use official sample and all samples are in the same git repository and Devfile does not support keep directory yet.
It is needed to use a git submodule in our sample for something like the vert.x Simple REST microservice and:

  • rework Devfile to use it;
  • run Vertx application in vertx component but not in maven with fat jar;

Reproduction Steps

OS and version:

Diagnostics:

@sleshchenko sleshchenko added the kind/task Internal things, technical debt, and to-do tasks to be performed. label Jun 27, 2019
@che-bot
Copy link
Contributor

che-bot commented Jan 15, 2020

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 15, 2020
@che-bot che-bot closed this as completed Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

2 participants