Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple plugin registries to be added to che #16258

Open
l0rd opened this issue Mar 6, 2020 · 11 comments
Open

Allow multiple plugin registries to be added to che #16258

l0rd opened this issue Mar 6, 2020 · 11 comments
Labels
area/dashboard area/editor/theia Issues related to the che-theia IDE of Che area/plugin-broker help wanted Community, we are fully engaged on other issues. Feel free to take this one. We'll help you! kind/enhancement A feature request - must adhere to the feature request template. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@l0rd
Copy link
Contributor

l0rd commented Mar 6, 2020

Is your enhancement related to a problem?

We already have an issue to support multiple devfile registries (#13961). This is about supporting multiple plugin registries.

Currently referring to alternative plugin registries is possible with the registryUrl field in a devfile chePlugin specification. But that is limited. For example it would not work for the following scenario

I have already deployed Che and I want to add a devfile registry (for example the z/OS team devfiles). These devfiles refer to plugins of a distinct registry (the z/OS team plugins). When the image of the devfile registry is built we do not know yet the plugin registry URL and therefore we we cannot add the registryUrl field in the devfiles.

Describe the solution you'd like

So we need to be able to specify multiple default che.workspace.plugin_registry_urls as a wsmaster property, to display all of them on the dashboard and in che-theia plugins view.

@l0rd l0rd added kind/enhancement A feature request - must adhere to the feature request template. area/dashboard area/che-server area/editor/theia Issues related to the che-theia IDE of Che area/plugin-broker labels Mar 6, 2020
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Mar 6, 2020
@tolusha
Copy link
Contributor

tolusha commented Mar 6, 2020

@l0rd
pls set the priority

@l0rd l0rd added severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Mar 6, 2020
@ericwill ericwill mentioned this issue Mar 12, 2020
50 tasks
@nickboldt nickboldt added this to the 7.12 milestone Mar 27, 2020
@nickboldt
Copy link
Contributor

Assuming this won't be done in time for 7.11, so setting milestone 7.12. P1 SEV1.

@ericwill
Copy link
Contributor

ericwill commented Apr 1, 2020

Assuming this won't be done in time for 7.11, so setting milestone 7.12. P1 SEV1.

Yes, this is a priority for 7.12.

@ericwill
Copy link
Contributor

ericwill commented Apr 6, 2020

I did some preliminary investigation and this is what I found -- please correct me if I am wrong.

The relevant code lives in che-theia, specifically ./extensions/eclipse-che-theia-plugin-ext/src/browser/plugin. There actually is support for adding other registries as a user setting (or via the plugins view). The issue is that none of the plugins in these registries are visible in the list, or even installable -- though Che does recognize them on some level as the "count" of plugins does increase when adding a second registry. The only plugins that seem to be visible in the list or installable are the ones available in the default registry. This registry is stored in the CHE_WORKSPACE_PLUGIN__REGISTRY__URL environment variable.

In theory all that's needed to enable multiple registries is to switch from using only the environment variable defined registry, to using all the plugins available from the list of registries in the user settings.

@ericwill ericwill added the help wanted Community, we are fully engaged on other issues. Feel free to take this one. We'll help you! label Apr 6, 2020
@ericwill ericwill removed this from the 7.12 milestone Apr 6, 2020
@nickboldt
Copy link
Contributor

So... I guess it's safe to say this isn't happening in 7.14 / CRW 2.2. :(

@nickboldt nickboldt removed the severity/P1 Has a major impact to usage or development of the system. label Jun 3, 2020
@nickboldt
Copy link
Contributor

Contribution from external teams will be needed if this is to be done in the 2.3 timeframe.

@nickboldt
Copy link
Contributor

@cwsolee is this something your team might want to contribute? Or is this something for Jasper Chui to look at?

@cwsolee
Copy link

cwsolee commented Jul 16, 2020

@nickboldt , I'm not clear what this PR is all about, safe for me to say it's not on my radar.

@nickboldt nickboldt added this to the 7.x milestone Jul 16, 2020
@nickboldt
Copy link
Contributor

This isn't a PR, it's a feature request... but thanks for the reply.

@elsony any input here?

@elsony
Copy link

elsony commented Jul 22, 2020

The original team that does the implementation of the multiple devfile registry #13961 has moved on to work on some other projects. Therefore, there is no resource on the Codewind side to work on this feature.

@che-bot
Copy link
Contributor

che-bot commented Jan 20, 2021

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 20, 2021
@ericwill ericwill added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dashboard area/editor/theia Issues related to the che-theia IDE of Che area/plugin-broker help wanted Community, we are fully engaged on other issues. Feel free to take this one. We'll help you! kind/enhancement A feature request - must adhere to the feature request template. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

8 participants