Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align the GitHub authentication plugin with the latest vscode GitHub PR plugin #17684

Closed
vinokurig opened this issue Aug 21, 2020 · 1 comment · Fixed by eclipse-che/che-theia#841
Closed

Align the GitHub authentication plugin with the latest vscode GitHub PR plugin #17684

vinokurig opened this issue Aug 21, 2020 · 1 comment · Fixed by eclipse-che/che-theia#841
Assignees
@vinokurig
Labels
area/plugins kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.
Milestone
7.21

Comments

@vinokurig
Copy link
Contributor

Is your task related to a problem? Please describe.

The authentication plugin API is going to be applied in theia. This API gives an ability to use the latest vscode GitHub PR plugin and to authenticate the plugin with the oAuth provider from Che.

Describe the solution you'd like

We need to update the GitHub-oauth-plugin in che-theia to use the GitHub oauth provider from Che as an authentication provider for the vscode GitHub PR plugin. This will replace the current temporary solution: injecting GitHub token to the plugin's config and asking user to refresh the page.

Describe alternatives you've considered

Additional context

fixes #14217
@vinokurig vinokurig added the kind/task Internal things, technical debt, and to-do tasks to be performed. label Aug 21, 2020
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Aug 21, 2020
@ericwill ericwill mentioned this issue Aug 21, 2020
Closed
32 tasks
@amisevsk amisevsk added area/editor/theia Issues related to the che-theia IDE of Che area/plugins severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Aug 21, 2020
@amisevsk
Copy link
Contributor

Setting P1 as I'd love to have better GitHub integration; pushing changes to 2fa accounts can be tedious. @ericwill feel free to relabel if needed.

@vinokurig vinokurig mentioned this issue Aug 26, 2020
Merged
@azatsarynnyy azatsarynnyy removed the area/editor/theia Issues related to the che-theia IDE of Che label Aug 27, 2020
@ericwill ericwill mentioned this issue Sep 10, 2020
Closed
29 tasks
@ericwill ericwill added this to the 7.20 milestone Sep 18, 2020
@ericwill ericwill mentioned this issue Oct 1, 2020
Closed
27 tasks
@ericwill ericwill modified the milestones: 7.20, 7.21 Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vinokurig vinokurig

Labels
area/plugins kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
7.21
Development

Successfully merging a pull request may close this issue.

Register GitHub Authentication provider for the vscode GitHub PR plugin eclipse-che/che-theia
5 participants
@azatsarynnyy @ericwill @vinokurig @amisevsk @che-bot