Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "Reload" button to the message panel from "GitHub authenticate". #17889

Closed
monaka opened this issue Sep 17, 2020 · 4 comments
Closed

Add "Reload" button to the message panel from "GitHub authenticate". #17889

monaka opened this issue Sep 17, 2020 · 4 comments
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/enhancement A feature request - must adhere to the feature request template. severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@monaka
Copy link
Member

monaka commented Sep 17, 2020

Is your enhancement related to a problem? Please describe.

There is no "Reload" button in the message panel generated by the "GitHub authenticate" command.

Screenshot 2020-09-15 at 09 09 55

They can reload by their browser's menu or keybind for now. But it's better to provide "Reload" button for their user experience.

Describe the solution you'd like

"Reload" button is added. Like this.

Screenshot 2020-09-17 at 08 52 26

It calls navigator.window.reload(false) inside.

Describe alternatives you've considered

Providing "Reload" menu. (Probably the sub-menu in "File" section.)

Additional context

I've already implemented it on my PizzaFactory instance and tested by hand. I'm going to send PR.
@monaka monaka added kind/enhancement A feature request - must adhere to the feature request template. area/editor/theia Issues related to the che-theia IDE of Che labels Sep 17, 2020
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Sep 17, 2020
@monaka monaka mentioned this issue Sep 17, 2020
Closed
@azatsarynnyy azatsarynnyy added severity/P2 Has a minor but important impact to the usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Sep 17, 2020
@azatsarynnyy
Copy link
Member

Nice UX improvement!

@vinokurig
Copy link
Contributor

The vscode GitHub Pull Request plugin is going to be updated to the latest version: #16741. In the latest version the authentication works through the authentication plugin API which is already introduced in theia: eclipse-theia/theia#8402. It means that we will register our own GitHub authentication provider instead of injecting token to preferences so this notification will be removed.

I am OK to have it as a temporary improvement.

@monaka
Copy link
Member Author

monaka commented Sep 17, 2020 •
edited
Loading

@vinokurig Thank you for the good news.
I keep this PR as it will take a little time applying the authentication plugin API to Che-Theia.

@monaka
Copy link
Member Author

monaka commented Oct 31, 2020

As #16741 was closed, this issue is deprecated. I close this.

@monaka monaka closed this as completed Oct 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/enhancement A feature request - must adhere to the feature request template. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add "Reload" button to the message panel from "GitHub authenticate". eclipse-che/che-theia
4 participants
@monaka @azatsarynnyy @vinokurig @che-bot