Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean log output from Resources Monitor Plugin #18841

Closed
svor opened this issue Jan 20, 2021 · 1 comment
Closed

Clean log output from Resources Monitor Plugin #18841

svor opened this issue Jan 20, 2021 · 1 comment
Assignees
@svor
Labels
area/plugins kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@svor
Copy link
Contributor

svor commented Jan 20, 2021

Is your task related to a problem? Please describe.

In case if Resources Monitor plug-in cannot read workspace's pod information or connect to the Metrics server, or read metrics from the Metrics server, the plug-in throws exceptions into theia-ide container. The exception's message looks like:

Extension-Host:Promise rejection not handled in one second: Error: Cannot connect to Metrics Server. Status code: 404. Error: 404 page not found
 , reason: Error: Cannot connect to Metrics Server. Status code: 404. Error: 404 page not found
Extension-Host:With stack trace: Error: Cannot connect to Metrics Server. Status code: 404. Error: 404 page not found
    at ResMon.<anonymous> (/tmp/theia-unpacked/eclipse_che_resource_monitor_plugin.theia/lib/resource-monitor-plugin.js:147:35)
    at step (/tmp/theia-unpacked/eclipse_che_resource_monitor_plugin.theia/lib/resource-monitor-plugin.js:42:23)
    at Object.next (/tmp/theia-unpacked/eclipse_che_resource_monitor_plugin.theia/lib/resource-monitor-plugin.js:23:53)
    at fulfilled (/tmp/theia-unpacked/eclipse_che_resource_monitor_plugin.theia/lib/resource-monitor-plugin.js:14:58)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)

Describe the solution you'd like

Since these exceptions are expected we have to catch them and don't show the message in the log.

Additional context

Resources Monitor plugin PR: eclipse-che/che-theia#919
@svor svor added kind/task Internal things, technical debt, and to-do tasks to be performed. team/plugins severity/P2 Has a minor but important impact to the usage or development of the system. area/plugins labels Jan 20, 2021
@ericwill ericwill mentioned this issue Jan 20, 2021
Closed
33 tasks
@ericwill ericwill added this to the 7.26 milestone Jan 20, 2021
@ericwill ericwill removed this from the 7.26 milestone Feb 8, 2021
@svor
Copy link
Contributor Author

svor commented May 7, 2021

should be solved by eclipse-che/che-theia#1089

@svor svor closed this as completed May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@svor svor

Labels
area/plugins kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@svor @ericwill