Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Quarkus #5442

Open
arjantijms opened this issue May 7, 2024 · 11 comments
Open

Support for Quarkus #5442

arjantijms opened this issue May 7, 2024 · 11 comments

Comments

@arjantijms
Copy link
Contributor

See https://stackoverflow.com/questions/59079402/quarkus-extension-or-not-for-jsf

Maybe we could consider Quarkus support at some point.

@melloware
Copy link
Contributor

That would be awesome. I have been slowly refining and testing the MyFaces integration over the years.

@tandraschko
Copy link
Contributor

i can just say that it requires a lot of work and also changes on existing JSF impl code

IMO it would be cool if you guys would do it but IMO its not worth. MyFaces is running fine already on quarkus.

@melloware
Copy link
Contributor

I agree with @tandraschko it will be a lot of effort and maybe not worth your team's time.

@arjantijms
Copy link
Contributor Author

i can just say that it requires a lot of work and also changes on existing JSF impl code

IMO it would be cool if you guys would do it but IMO its not worth. MyFaces is running fine already on quarkus.

Maybe something to keep in mind, thanks for chiming in.

I'm also looking for the potentially making Soteria (Jakarta Security) work on Quarkus, which may then be a lot of work as well? Where is most of the work / time spend in making it compatible?

@tandraschko
Copy link
Contributor

tandraschko commented May 13, 2024

In short: Quarkus is not fully CDI compatible

some features are comopletely not supported (like e.g. injection in a non-cdi bean), something like Extensions must be completely rewritten in Quarkus API, which is split in build and runtime. Also scopes have a own API, this mostly requires some wrapping around existing scopes.

@tandraschko
Copy link
Contributor

You can just check our quarkus extensions: https://github.com/apache/myfaces/tree/main/extensions/quarkus

as i said, in addition to make this extension possible, it was needed to refactor some of the JSF Impl code.

@melloware
Copy link
Contributor

@arjantijms you can see the Quarkus JSF podcast here for the state of JSF on Quarkus: https://www.youtube.com/watch?v=DIN0I56-GR4

@BalusC
Copy link
Contributor

BalusC commented May 18, 2024

it was needed to refactor some of the JSF Impl code

To confirm, no changes in JSF/Faces API code was needed in MyFaces side? I.e. the code currently in Faces 5.0 branch is fine wrt Quarkus? https://github.com/jakartaee/faces/tree/5.0

@tandraschko
Copy link
Contributor

I am almost sure that i only modified impl for quarkus

@melloware
Copy link
Contributor

@arjantijms as far as Soteria goes the Quarkus team is super responsive to helping extension developers figure out issues and getting their extension to work with Quarkus. They have a Zulip channel and I have asked a bunch of questions when I was doing the PF, OmniFaces, Myfaces stuff and almost always got a great answer or another extension sample code to look at for what I was trying to accomplish.

@arjantijms
Copy link
Contributor Author

Thanks, sounds good. I moved it a little higher up on my TODO list ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants